CovModels: limit exponent shape parameters to 50 to prevent numerical errors#147
Merged
MuellerSeb merged 1 commit intodevelopfrom Mar 23, 2021
Merged
CovModels: limit exponent shape parameters to 50 to prevent numerical errors#147MuellerSeb merged 1 commit intodevelopfrom
MuellerSeb merged 1 commit intodevelopfrom
Conversation
… errors during fitting
MuellerSeb
added
bug
Member
Author
|
CI currently failing for linux wheels because of this: https://status.quay.io/ |
This was referenced Mar 22, 2021
LSchueler
approved these changes
Mar 23, 2021
Member
LSchueler
left a comment
LSchueler
left a comment
There was a problem hiding this comment.
Let's get this thing stable!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some models with shape parameters could run into numerical errors during variogram fitting, since their shape parameters had no upper bound.
Namely:
The new default upper bound for the shape parameter of these models is
50. (Can still be changed by the user)